Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips-N'-Tricks: homebrew.man.conf for Terminal.app #16099

Merged
merged 4 commits into from Oct 11, 2023

Conversation

heller
Copy link
Contributor

@heller heller commented Oct 10, 2023

Add instructions for fixing Terminal.app's "Open man Page" command by creating homebrew.man.conf.

Fixes #16074.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [-] Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • [-] Have you successfully run brew typecheck with your changes locally?
  • [-] Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far @heller! A few suggestions.

docs/Tips-N'-Tricks.md Outdated Show resolved Hide resolved
docs/Tips-N'-Tricks.md Outdated Show resolved Hide resolved
docs/Tips-N'-Tricks.md Outdated Show resolved Hide resolved
docs/Tips-N'-Tricks.md Outdated Show resolved Hide resolved
Update instructions: Append to the file from the shell, and fix permissions if on macOS Intel.

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Copy link
Contributor Author

@heller heller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions, thank you!

docs/Tips-N&#39;-Tricks.md Outdated Show resolved Hide resolved
docs/Tips-N&#39;-Tricks.md Outdated Show resolved Hide resolved
docs/Tips-N&#39;-Tricks.md Outdated Show resolved Hide resolved
@marc-medley
Copy link

marc-medley commented Oct 10, 2023

@heller, @MikeMcQuaid As noted in Issue #16074, I am working through some additional (hopefully, well thought-out & relevant) comments for your consideration.

I will be pondering/rethinking this issue over the weekend and will provide some re-focused comments sometime next week.

I would appreciated being allowed this week for adding such comments before the issue is closed out. Would this be possible? Thanks.

@heller
Copy link
Contributor Author

heller commented Oct 10, 2023

Reopening tickets in case of new information seems normal to me, but I defer to maintainers.

@MikeMcQuaid
Copy link
Member

@marc-medley Let's keep discussing the issue once it's closed and, if necessary and there's something additionally actionable beyond this PR, we'll reopen. Thanks!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock, @heller!

@MikeMcQuaid MikeMcQuaid merged commit 43e537a into Homebrew:master Oct 11, 2023
27 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
3 participants