Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: pre-install implicit dependencies #16118

Merged

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Oct 18, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A leftover from #15566: originally added in #12296, a dependency with [:build, :test] was assumed to be required for downloading or extracting a package's source. Now we have :implicit, so just check for that. This restores curl being pre-installed for any dependency with using: :homebrew_curl and subversion being pre-installed if needed on macOS 10.14 and earlier.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EricFromCanada!

@EricFromCanada EricFromCanada merged commit 3480dda into Homebrew:master Oct 18, 2023
27 checks passed
@EricFromCanada EricFromCanada deleted the preinstall-implicit-deps branch October 18, 2023 20:34
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants