Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore quarantine for linux cask download #16139

Merged
merged 3 commits into from Oct 25, 2023

Conversation

WangEdward
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Override the quarantine method for cask download on Linux. This should, in most cases, allow bump-cask-pr to function on Linux.

@MikeMcQuaid MikeMcQuaid requested a review from a team October 25, 2023 11:45
@Bo98
Copy link
Member

Bo98 commented Oct 25, 2023

Shouldn't Quarantine.available? return false on Linux? It checks for a working xattr.

The original quarantine method you're overriding has a return unless Quarantine.available?

SMillerDev
SMillerDev previously approved these changes Oct 25, 2023
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for me.

@SMillerDev SMillerDev dismissed their stale review October 25, 2023 12:24

Actually Bo's comment makes more sense

@Bo98
Copy link
Member

Bo98 commented Oct 25, 2023

I think I see the issue:

if !system_command(xattr, args: ["-h"], print_stderr: false).success?

This should probably be if xattr.nil? || !system_command(xattr, ...

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and thanks for suggestion @Bo98.

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @WangEdward!

@MikeMcQuaid MikeMcQuaid merged commit fa56f72 into Homebrew:master Oct 25, 2023
25 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants