Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in REXML gem as it doesn't ship with Ruby 3 #16150

Merged
merged 1 commit into from Oct 28, 2023
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 27, 2023

REXML doesn't ship with Ruby 3 (or well it sort of does as a bundled gem, but it isn't accessible through Bundler).

So we need to add it to the Gemfile here. While not strictly necessary for Ruby 2.6, let's do it everywhere for consistency.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Oct 28, 2023
@Bo98 Bo98 merged commit 97eda64 into Homebrew:master Oct 28, 2023
30 checks passed
@Bo98 Bo98 deleted the rexml-gem branch October 28, 2023 17:03
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants