Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use XDG_CACHE_HOME on Linux #16161

Merged

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Closes #16156

This variable was getting filtered out before so it wasn't possible for us to use it as the default for HOMEBREW_DEFAULT_CACHE and HOMEBREW_DEFAULT_LOGS. I'm no bash expert so if there's a better way to handle this let me know.

@Bo98
Copy link
Member

Bo98 commented Oct 29, 2023

You can just add it to USED_BY_HOMEBREW_VARS I think

This variable was getting filtered out before so it wasn't possible
for us to use it as the default for HOMEBREW_DEFAULT_CACHE
and HOMEBREW_DEFAULT_LOGS.
@carlocab carlocab merged commit 032ef75 into Homebrew:master Oct 29, 2023
27 checks passed
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @apainintheneck!

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs ignore XDG_CACHE_HOME env variable while processing HOMEBREW_CACHE and HOMEBREW_LOGS
4 participants