Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed "Twitter" to "饾晱 (Twitter)" in README.md description section #16169

Merged
merged 3 commits into from Oct 31, 2023
Merged

fix: changed "Twitter" to "饾晱 (Twitter)" in README.md description section #16169

merged 3 commits into from Oct 31, 2023

Conversation

BandhiyaHardik
Copy link
Contributor

@BandhiyaHardik BandhiyaHardik commented Oct 30, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This fixes #16168

MikeMcQuaid
MikeMcQuaid reviewed Oct 31, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @BandhiyaHardik.

For future reference: please don't open issues that you plan on immediately opening a PR for 鉂わ笍

@BandhiyaHardik
Copy link
Contributor Author

Makes sense, thanks @BandhiyaHardik.

For future reference: please don't open issues that you plan on immediately opening a PR for 鉂わ笍

Sorry About that I am new to opensource.

I will keep this in mind.

@MikeMcQuaid
Copy link
Member

@BandhiyaHardik No apologies needed and thanks for the PR! Policies like this vary from project to project; just letting you know ours.

@BandhiyaHardik
Copy link
Contributor Author

@BandhiyaHardik No apologies needed and thanks for the PR! Policies like this vary from project to project; just letting you know ours.

Yes. In Future i will keep this in mind when i contribute to brew

@MikeMcQuaid MikeMcQuaid merged commit a36e145 into Homebrew:master Oct 31, 2023
27 of 28 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: changed "Twitter" to "饾晱 (Twitter)" in README.md in Community Section
2 participants
@BandhiyaHardik @MikeMcQuaid