Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ActiveSupport try #16184

Merged
merged 1 commit into from Nov 6, 2023
Merged

Remove use of ActiveSupport try #16184

merged 1 commit into from Nov 6, 2023

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Nov 5, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This was used in only a handful of places, where safe navigation and typechecking are generally better approaches (there are some suboptimal APIs that make this less clean in some cases, however).

@@ -1,6 +1,8 @@
# typed: true
# frozen_string_literal: true

require "delegate"
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have previously depended on the require within try itself.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit ff404fe into Homebrew:master Nov 6, 2023
27 checks passed
@dduugg dduugg mentioned this pull request Nov 7, 2023
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants