Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/curl: fix Digest::SHA256 typo #16202

Merged
merged 1 commit into from Nov 10, 2023
Merged

utils/curl: fix Digest::SHA256 typo #16202

merged 1 commit into from Nov 10, 2023

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Should fix the error seen in Homebrew/homebrew-core#153647 (CI logs). This was introduced in e5d656b and Digest::256 seems to be the intended one.

@ZhongRuoyu
utils/curl: fix Digest::SHA256 typo
ac7a1bf 
Should fix the error seen in Homebrew/homebrew-core#153647 [^1]. This
was introduced in e5d656b and `Digest::256` seems to be the intended
one.

[^1]: https://github.com/Homebrew/homebrew-core/actions/runs/6805354565/job/18504732312?pr=153647#step:4:36
@ZhongRuoyu ZhongRuoyu mentioned this pull request Nov 10, 2023
Merged
1 task
MikeMcQuaid
MikeMcQuaid approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@MikeMcQuaid MikeMcQuaid merged commit 22a56e8 into Homebrew:master Nov 10, 2023
27 checks passed
@ZhongRuoyu ZhongRuoyu deleted the digest-sha256 branch November 11, 2023 03:31
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZhongRuoyu @MikeMcQuaid