Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage tracking #16204

Merged
merged 1 commit into from Nov 11, 2023
Merged

Improve coverage tracking #16204

merged 1 commit into from Nov 11, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 11, 2023

  • Fix integration test coverage tracking not working properly (would overwrite each other as the unique ID was generated but not read) - this regressed as the fix for Cleanup CodeCov tests output spam #14662 overcombined command names
  • Fix brew.rb not being tracked
  • Simplify integration test unique ID generation (to avoid regressing back to the state prior to Cleanup CodeCov tests output spam #14662 too much - it will unavoidably have a little but still should be significantly shorter than before)
  • Exclude sorbet and yard directories from coverage tracking - these are used in non-brew tools and are out of scope for rspec testing.
  • Fix up some regexes and add some groups for livecheck etc.
  • Remove RubyGems < 2.2 compatibility code. We already no longer support it:
    raise "RubyGems too old!" if Gem::Version.new(Gem::VERSION) < Gem::Version.new("2.2.0")

@Bo98
Copy link
Member Author

Bo98 commented Nov 11, 2023

72.40% (+5.46%)

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great: more coverage less code. Nice work as usual @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 275078d into Homebrew:master Nov 11, 2023
27 checks passed
@Bo98 Bo98 deleted the coverage-fixes branch November 11, 2023 13:04
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants