Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: Remove path attr to reduce code complexity #16244

Merged
merged 5 commits into from Nov 23, 2023

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Nov 21, 2023

path attribute is used only once, and it is easier to calculate it on the fly than to update its state after different methods.

Factored out from #16238 to keep it clean.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

`path` attribute is used only once, and it is easier to calculate
it on the fly than to update its state after different methods.
"ActiveSupport adds blank? to NilClass."
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks @abitrolly!

@MikeMcQuaid MikeMcQuaid merged commit 942e77d into Homebrew:master Nov 23, 2023
27 checks passed
@abitrolly abitrolly deleted the depath-create branch November 23, 2023 16:09
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants