New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate --new-formula
/--new-cask
options.
#16297
Deprecate --new-formula
/--new-cask
options.
#16297
Conversation
d033c0e
to
5097d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @reitermarkus, looking good so far. A few suggestions so we can get this deprecated sooner rather than later.
new_cask = args.new? || args.new_cask? | ||
new_formula = args.new? || args.new_formula? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_cask = args.new? || args.new_cask? | |
new_formula = args.new? || args.new_formula? | |
new_cask = args.new? | |
if args.new_cask? | |
# odeprecated "brew audit --new-cask" | |
new_cask = true | |
end | |
new_formula = args.new? | |
if args.new_formula? | |
# odeprecated "brew audit --new-formula" | |
new_formula = true | |
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reitermarkus Still think this would be good to do so we delete and print deprecation messages on usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
odeprecated
is automatically done by CLI::Parser
once the replacement
s are uncommented on the switch
calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup but we're reliant on the commenting and changing of odeprecated
to odisabled
process to get this code removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already added a odeprecated
comment above on the switch
calls. Once the switch
calls use disable: true
, calling args.new_formula?
/args.new_cask?
here will fail CI anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added a comment and disable: false
to make it greppable.
5097d29
to
2b006aa
Compare
2b006aa
to
a384b1c
Compare
a384b1c
to
0a4d10b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @reitermarkus!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?See Homebrew/homebrew-cask#161724.
Both
--new-formula
as well as--new-cask
do the same thing as--new
, so they're not needed anymore.