Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/service: assume no service system during generic OS tests #16304

Merged
merged 1 commit into from Dec 7, 2023
Merged

utils/service: assume no service system during generic OS tests #16304

merged 1 commit into from Dec 7, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 7, 2023 •
edited

Should fail until rebased on #16303.

Provides a test flow that's different to the usual macOS and Linux runs, increasing coverage.

MikeMcQuaid
MikeMcQuaid approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@Bo98 Bo98 merged commit c32bd1c into Homebrew:master Dec 7, 2023
26 checks passed
@Bo98 Bo98 deleted the generic-service branch December 7, 2023 22:02
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bo98 @MikeMcQuaid