Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially support pour_bottle? in API #16305

Merged
merged 1 commit into from Dec 7, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 7, 2023

Fixes Homebrew/homebrew-core#156536.

Block syntax of pour_bottle? is not supported, as that involves Ruby code. It seems we've phased that out in Homebrew/core already.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 8b98411 into Homebrew:master Dec 7, 2023
26 checks passed
@Bo98 Bo98 deleted the pour_bottle-api branch December 7, 2023 20:45
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants