Deprecate, disable & delete code for Homebrew 4.2.0 #16306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
commented
Dec 7, 2023
Comment on lines
-3375
to
-3376
| def plist_options(options) | ||
| odisabled "plist_options", "service.require_root" |
There was a problem hiding this comment.
Given the number of errors in audit CI here: it seems this deprecation didn't work and we will probably have to restart the process and figure out why.
There was a problem hiding this comment.
Ah right it did work, just not for every formula because of:
brew/Library/Homebrew/extend/kernel.rb
Line 129 in c32bd1c
Which doesn't really work with things that are future-deprecated like the PHP versioned formulae.
Given we have to deal with things when they get removed anyway, and the deprecation cycle of formulae is significantly longer than brew's, this check is probably not as useful as it seems.
There was a problem hiding this comment.
Handled the remaining formulae in Homebrew/homebrew-core#156780.
Bo98
force-pushed
the
4.2.0-deprecations
branch
from
740cae5
to
b42256d
Compare
Bo98
commented
Dec 7, 2023
Comment on lines
-146
to
+153
| # odeprecated "Language::Python::Virtualenv.virtualenv_create's without_pip" unless without_pip | ||
| # Limit deprecation to 3.12+ for now (or if we can't determine the version). | ||
| # Some used this argument for setuptools, which we no longer bundle since 3.12. | ||
| unless without_pip | ||
| python_version = Language::Python.major_minor_version(python) | ||
| if python_version.nil? || python_version.null? || python_version >= "3.12" | ||
| raise ArgumentError, "virtualenv_create's without_pip is deprecated starting with Python 3.12" | ||
| end | ||
| end |
There was a problem hiding this comment.
This one is perhaps unusual but it's either this or don't deprecate at all I reckon. GitHub search shows 134 usages in third-party taps (and once in homebrew-core).
MikeMcQuaid
approved these changes
Dec 11, 2023
MikeMcQuaid
added a commit
to Homebrew/homebrew-test-bot
that referenced
this pull request
Dec 11, 2023
`--new-formula` was deprecated in Homebrew/brew#16306
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
Bo98
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
Bo98
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306. Co-authored-by: Bo Anderson <mail@boanderson.me>
Bo98
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
Bo98
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306.
Bo98
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2023
Needed after Homebrew/brew#16306. Co-authored-by: Bo Anderson <mail@boanderson.me>
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 14, 2023
Needed after Homebrew/brew#16306.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16294 (comment)