Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Hash#except, remove ActiveSupport 馃惖-patch #16320

Merged
merged 6 commits into from Dec 12, 2023

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Dec 12, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to #16190

Ruby 3.0 added Hash#except, so we no longer need the ActiveSupport monkey-patch.

Note that there was also a Hash#except! monkey-patch in the ActiveSupport module. The only usage that I could find was in livecheck/livecheck. I've refactored those away, and added strict typing to the file while I was there.

@dduugg
Copy link
Sponsor Member Author

dduugg commented Dec 12, 2023

I also found that we were using a Hash#slice! monkey-patch within a dev command, so I've refactored that out as well

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid merged commit 7755004 into Homebrew:master Dec 12, 2023
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @dduugg!

@dduugg dduugg deleted the use-native-except branch December 12, 2023 20:03
@dduugg dduugg mentioned this pull request Dec 12, 2023
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants