New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create: modify cask template #16345
create: modify cask template #16345
Conversation
I would note that we currently don't include an explicit livecheck stanza for casks using the |
aff37ef
to
cbe2c1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes/suggestions/thoughts.
This PR does the following:
- ..snip..
- Adds livecheck and zap to the list of required stanzas
When I reviewed the code, I think this may have only been done in the docs, but not actually enforced in any of the code through brew style
/ brew audit
/ similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as usual, thanks @razvanazamfirei!
Noticed one tiny bit of pedantry I'm committing and then will auto-merge.
@0xdevalias please do not review any more PRs until you are a maintainer and focus on your own, thanks. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR does the following:
create
commandlivecheck
andzap
to the list of required stanzasCloses #16342.