Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "an artifact with this name already exists on the workflow run" #16347

Merged
merged 1 commit into from Dec 16, 2023
Merged

Fix "an artifact with this name already exists on the workflow run" #16347

merged 1 commit into from Dec 16, 2023

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Dec 16, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Two days ago my tap started failing because the upstream actions/upload-artifact@main was bumped to v4. This version no longer allows to upload artifacts with the same name for multiple jobs.

Example: https://github.com/autobrew/homebrew-cran/actions/runs/7232216444

So we either need to make the name parameter unique or stick with v3 for now.

@jeroen jeroen changed the title Fix workflow for duplicate names Fix "an artifact with this name already exists on the workflow run" Dec 16, 2023
@Bo98
Copy link
Member

Bo98 commented Dec 16, 2023

Yeah we're sticking with v3 ourselves until we figure out the best way to handle v4, probably after the new year.

@Bo98 Bo98 merged commit a60c58c into Homebrew:master Dec 16, 2023
24 checks passed
@jeroen jeroen deleted the upload-artifact branch December 16, 2023 13:51
@jeroen
Copy link
Contributor Author

jeroen commented Jan 10, 2024

FYI, v4 is very buggy right now, don't upgrade yet: actions/download-artifact#249

@Bo98
Copy link
Member

Bo98 commented Jan 10, 2024

We're aware, though there's still stuff we have to do anyway before v4 can be adopted and that work will work with the existing v3.

davidchall added a commit to davidchall/homebrew-hep that referenced this pull request Jan 31, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants