New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaner: remove *.tbd #16355
cleaner: remove *.tbd #16355
Conversation
@AkihiroSuda Do you have any examples beyond Homebrew/homebrew-core#157617 for things that might need this? Thanks! |
I don't know. |
Bit of a weird one given shipping both a .tbd and a .dylib seems pointless - Apple ship .tbd to avoid shipping .dylib in their SDKs. It's not wrong per se but instead rather meaningless. It seems to be a new CMake feature. We could clean them like we do for brew/Library/Homebrew/cleaner.rb Line 7 in b72421e
brew/Library/Homebrew/cleaner.rb Line 128 in b72421e
|
This seems like a good idea until we have a use for them 👍🏻 |
I understand that |
I'd rather report those to the relevant upstream project as a bug instead of preemptively working around them by always keeping the There's another formula where we go out of our way to remove them because they break the bottle. |
Yeah it should be safe to treat them exactly as we do For CMake, it happens if |
For Homebrew#16355 (comment) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
e815793
to
009318d
Compare
*.tbd
Updated PR to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @AkihiroSuda!
For #16355 (comment)
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Needed by: