Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/lines: consistency with single non-runtime Python #16364

Merged
merged 1 commit into from Dec 20, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 19, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A couple PRs in homebrew-core were merged for modifying python@3.11 --> python@3.12 but the actual build/test was still using python3.11 since the corresponding reference was not updated.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, good catch, thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit 4d93a50 into Homebrew:master Dec 20, 2023
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
@cho-m cho-m deleted the pybuild-rubocopy branch March 5, 2024 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants