Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: fix formula path #16399

Merged
merged 1 commit into from Dec 26, 2023
Merged

Conversation

razvanazamfirei
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR addresses a small issue regarding error messages for cask token conflicts. Presently, when a token conflict arises, an error message is displayed with an incorrect path. For example (highlights mine):

possible duplicate, cask token conflicts with Homebrew core formula:
https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula//Formula/o/ollama.rb
                                                   ^^^^^^^^^^^^^^^^^

This PR corrects the path in the error message to ensure it reflects the correct location.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @razvanazamfirei!

@MikeMcQuaid MikeMcQuaid merged commit e2e6f25 into Homebrew:master Dec 26, 2023
24 checks passed
@razvanazamfirei razvanazamfirei deleted the audit-formula-fix branch December 26, 2023 14:23
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants