rubocops/components_redundancy: stable/head block removal #16413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
force-pushed
the
rubocop-remove-stable-head-block
branch
from
8431c4e
to
573695b
Compare
Bo98
approved these changes
Dec 30, 2023
| unless stable_block.body.nil? | ||
| child_nodes = stable_block.body.begin_type? ? stable_block.body.child_nodes : [stable_block.body] | ||
| if child_nodes.all? { |n| n.send_type? && STABLE_BLOCK_METHODS.include?(n.method_name) } | ||
| problem "`stable do` should not be present with only #{STABLE_BLOCK_METHODS.join("/")}" |
There was a problem hiding this comment.
Feels like there's a better way to word this but I don't have any suggestions. Maybe worth mentioning it's redundant rather than broken.
MikeMcQuaid
reviewed
Dec 31, 2023
cho-m
force-pushed
the
rubocop-remove-stable-head-block
branch
from
573695b
to
abb3e33
Compare
When a `stable do` or `head do` block only contains `url`, `sha256`, `mirror`, and/or `version`, then the block should be removed.
cho-m
force-pushed
the
rubocop-remove-stable-head-block
branch
from
abb3e33
to
b4657e1
Compare
MikeMcQuaid
approved these changes
Jan 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
stable doorhead doblock only containsurl,sha256,mirror, and/orversion, then the block should be removed.brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?