Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some specifics on gems (and maybe pips) #16418

Merged
merged 1 commit into from Jan 15, 2024
Merged

Add some specifics on gems (and maybe pips) #16418

merged 1 commit into from Jan 15, 2024

Conversation

jaymzh
Copy link
Contributor

@jaymzh jaymzh commented Jan 1, 2024

In Homebrew/homebrew-core#157910 we discussed
some improvements to docs on setting up gems. THis is an attempt at some
docs for that.

If someone can help with pip docs for this I'll add it too.

Signed-off-by: Phil Dibowitz phil@ipom.com

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@jaymzh jaymzh mentioned this pull request Jan 1, 2024
Merged
6 tasks
@jaymzh jaymzh changed the title Add some specifics onm gems (and maybe pips) Add some specifics on gems (and maybe pips) Jan 1, 2024
@jaymzh jaymzh marked this pull request as ready for review January 1, 2024 23:12
MikeMcQuaid
MikeMcQuaid reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jaymzh, much appreciated and looking great so far.

docs/Formula-Cookbook.md Outdated Show resolved Hide resolved
docs/Formula-Cookbook.md Outdated Show resolved Hide resolved
docs/Formula-Cookbook.md Outdated Show resolved Hide resolved
@jaymzh
Add some specifics on gems (and maybe pips)
9f11ef9 
In Homebrew/homebrew-core#157910 we discussed
some improvements to docs on setting up gems. THis is an attempt at some
docs for that.

If someone can help with pip docs for this I'll add it too.

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@jaymzh
Copy link
Contributor Author

jaymzh commented Jan 13, 2024

Oh I'm always stoke to see folks using MDL linters (I'm the primary maintainer these days)!

@MikeMcQuaid
Copy link
Member

Oh I'm always stoke to see folks using MDL linters (I'm the primary maintainer these days)!

Oh, great: thanks for your work on such a brilliant tool!

MikeMcQuaid
MikeMcQuaid approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @jaymzh, much appreciated!

@MikeMcQuaid MikeMcQuaid merged commit 1556413 into Homebrew:master Jan 15, 2024
24 checks passed
@jaymzh jaymzh deleted the gem-docs branch January 16, 2024 00:27
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@cho-m cho-m Awaiting requested review from cho-m

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaymzh @MikeMcQuaid @cho-m