Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump rubocop-rspec from 2.25.0 to 2.26.1 in /Library/Homebrew #16440

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 6, 2024

Bumps rubocop-rspec from 2.25.0 to 2.26.1.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.26.1

  • Fix an error for RSpec/SharedExamples when using examples without argument. (@​ydah)

RuboCop RSpec v2.26.0

  • Add new RSpec/RedundantPredicateMatcher cop. (@​ydah)
  • Add new RSpec/RemoveConst cop. (@​swelther)
  • Add support for correcting "it will" (future tense) for RSpec/ExampleWording. (@​jdufresne)
  • Add support for symbol style for RSpec/SharedExamples. (@​jessieay)
  • Ensure PendingWithoutReason can detect violations inside shared groups. (@​robinaugh)
Changelog

Sourced from rubocop-rspec's changelog.

2.26.1 (2024-01-05)

  • Fix an error for RSpec/SharedExamples when using examples without argument. ([@​ydah])

2.26.0 (2024-01-04)

  • Add new RSpec/RedundantPredicateMatcher cop. ([@​ydah])
  • Add new RSpec/RemoveConst cop. ([@​swelther])
  • Add support for correcting "it will" (future tense) for RSpec/ExampleWording. ([@​jdufresne])
  • Add support for symbol style for RSpec/SharedExamples. ([@​jessieay])
  • Ensure PendingWithoutReason can detect violations inside shared groups. ([@​robinaugh])
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Jan 6, 2024
@p-linnane
Copy link
Member

I've fixed the 3 failures related to using future tense in tests. Will need help with the last failure:

Library/Homebrew/test/requirement_spec.rb:170:7: C: RSpec/RemoveConst: Do not use remove_const in specs. Consider using e.g. stub_const.
      self.class.send(:remove_const, const)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@p-linnane p-linnane requested a review from Bo98 January 6, 2024 17:58
@Bo98
Copy link
Member

Bo98 commented Jan 6, 2024

Will need help with the last failure

Will check shortly. I'm guessing it's trying to test the class name check

@p-linnane p-linnane force-pushed the dependabot/bundler/Library/Homebrew/rubocop-rspec-2.26.1 branch from bdf2034 to f675024 Compare January 6, 2024 18:03
dependabot bot and others added 5 commits January 8, 2024 18:39
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.25.0 to 2.26.1.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.25.0...v2.26.1)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bo Anderson <mail@boanderson.me>
@Bo98 Bo98 force-pushed the dependabot/bundler/Library/Homebrew/rubocop-rspec-2.26.1 branch from bfee75c to 43e5352 Compare January 8, 2024 18:41
@MikeMcQuaid MikeMcQuaid merged commit e74dc47 into master Jan 8, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dependabot/bundler/Library/Homebrew/rubocop-rspec-2.26.1 branch January 8, 2024 19:05
@MikeMcQuaid
Copy link
Member

Thanks @Bo98 and @p-linnane!

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants