Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulary: allow for more keyless fields when loading from API #16459

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These were fields I missed the first time around in #16420. Now the values should line up with the expected values.

I checked it with apainintheneck/homebrew-dev-utils#36 and a new branch I'm working on locally based on #16433 (comment).

These were fields I missed the first time around. Now the values
line up with the expected values.
@apainintheneck
Copy link
Contributor Author

Looks like there is an unrelated docs generation error.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apainintheneck, makes sense!

@MikeMcQuaid MikeMcQuaid merged commit 398d7db into Homebrew:master Jan 10, 2024
23 of 24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants