Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: split audit_revision_and_version_scheme. #16466

Merged
merged 1 commit into from Jan 12, 2024
Merged

formula_auditor: split audit_revision_and_version_scheme. #16466

merged 1 commit into from Jan 12, 2024

Conversation

MikeMcQuaid
Copy link
Member

Separate this into two methods so we can have separate skips for each.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 12, 2024
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 12, 2024
Merged
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Jan 12, 2024
@MikeMcQuaid
check-labels: add CI-skip-revision-audit label.
dba5637 
This allows passing --skip-revision-audit to brew test-bot.

Depends on Homebrew/brew#16466
Depends on Homebrew/homebrew-test-bot#998
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 12, 2024
Merged
carlocab
carlocab approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ✅ to ensure we can deploy a fix, but I think the correct thing to do here is to make the revision audit smarter.

Library/Homebrew/formula_auditor.rb

current_version_scheme = formula.version_scheme

previous_committed, = committed_version_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#committed_version_info is cached, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup: https://github.com/Homebrew/brew/pull/16466/files#diff-a899f471366b675f5bc416761c9b8820f944db5ca9a5b5fb62a957bbb399d42cR982

@carlocab
Copy link
Member

Oops, looks like there are callers that need fixing?

@MikeMcQuaid
formula_auditor: split audit_revision_and_version_scheme.
724e14e 
Separate this into two methods so we can have separate skips for each.
@MikeMcQuaid MikeMcQuaid force-pushed the audit_separate_revision_version_scheme branch from 4385d4e to 724e14e Compare January 12, 2024 14:18
@MikeMcQuaid MikeMcQuaid removed the critical Critical change which should be shipped as soon as possible. label Jan 12, 2024
@MikeMcQuaid
Copy link
Member Author

but I think the correct thing to do here is to make the revision audit smarter.

I'm game for that but I think it's a longer lift and this code is really hard to get right.

I think having more labels that allow maintainers to override some of these audits when they don't make sense makes the most sense (at least in the short-term).

@MikeMcQuaid
Copy link
Member Author

Oops, looks like there are callers that need fixing?

@carlocab Thanks, should be fixed.

@MikeMcQuaid MikeMcQuaid merged commit a7615b7 into Homebrew:master Jan 12, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the audit_separate_revision_version_scheme branch January 12, 2024 14:27
@Bo98
Copy link
Member

Bo98 commented Jan 12, 2024 •
edited

Generally ok with skipping should only increment by 1, less keen on being allowed to skip the decrease one as that in the past has erroneously been seen as a false positive when it actually isn't (e.g. another PR has revision bumped the same formula) and I don't see a scenario where publishing new bottles on an old revision is a good idea.

But in general 👍

@MikeMcQuaid
Copy link
Member Author

@Bo98 Yeh, I'd be game to split this audit (and others) to be even more granular as desired.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @carlocab @Bo98 @BrewTestBot