Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove canonical_segments check #16509

Merged
merged 1 commit into from Jan 21, 2024
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jan 19, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Ruby 3.1 ships with rubygems 3.3.3, which was released 2021-12-24. Gem::Version#canonical_segments was introduced in 2016.

@Bo98
Copy link
Member

Bo98 commented Jan 19, 2024

This script is used on arbitrary Rubies in the PATH etc to check if it is Ruby 3.1 or later. Though if it still errors out with a non-zero exit code and prints nothing to stdout (stderr is fine since we do 2>/dev/null) on very old Rubies then it's probably ok to remove the check.

@dduugg
Copy link
Sponsor Member Author

dduugg commented Jan 19, 2024

Yeah, tbc I mean that primarily as a contrast. Even macos system ruby ships with rubygems 3.0.3, released in 2019. But reasonable enough if folks want to maintain support for the oldest rubies.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving that it will fail as @Bo98 says: makes sense, thanks @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 25bef3d into Homebrew:master Jan 21, 2024
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants