Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Time refinement with Timer Util #16544

Merged
merged 1 commit into from Jan 30, 2024
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jan 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Refinements are problematic for reasons covered in past PRs. This PR removes one of the two remaining refinements (Time) in favor of static Utils methods.

@dduugg dduugg force-pushed the timer-util branch 3 times, most recently from b53971e to 4326e64 Compare January 30, 2024 02:24
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 022fa79 into Homebrew:master Jan 30, 2024
24 checks passed
@dduugg dduugg deleted the timer-util branch January 30, 2024 17:13
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants