Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common-Issues: Documents resolving dual installations from Migration Assistant copies #16668

Merged
merged 7 commits into from Feb 19, 2024

Conversation

colindean
Copy link
Member

This is an extract and refactor of the linked Discussions post from @gromgit.

https://github.com/orgs/Homebrew/discussions/4397#discussioncomment-5567441 has been useful to at least a few people in my org this week as it’s clearly “new laptop season” and we’re hitting the ~last of the Intel Macs still in service, those put in service 2020 when my company switched wholesale to M1 macs in the 2021 refresh cycle. I expect more people to be hitting this problem en masse in the next few weeks/months as they switch architectures.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
colindean and others added 3 commits February 15, 2024 17:06
Co-authored-by: Patrick Linnane <patrick@linnane.io>
…before I drop into a codespace to fight mdl
docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
Copy link
Member

@EricFromCanada EricFromCanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll add each line as a new section in the same list item and should allow the mdl check to pass.

docs/Common-Issues.md Outdated Show resolved Hide resolved
docs/Common-Issues.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Knibbe <enk3@outlook.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid
Copy link
Member

Thanks @colindean!

@MikeMcQuaid MikeMcQuaid merged commit 52d73a1 into Homebrew:master Feb 19, 2024
24 checks passed
@colindean colindean deleted the patch-4 branch February 20, 2024 17:37
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants