Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop .rbi exclusion #16673

Merged
merged 6 commits into from Feb 19, 2024
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Feb 16, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I've filed an issue upstream, but for now let's avoid using the problematic inclusion style.

@dduugg dduugg marked this pull request as draft February 16, 2024 01:36
@apainintheneck
Copy link
Contributor

This issue might be useful as a reference: Shopify/rubocop-sorbet#94

Library/.rubocop.yml Outdated Show resolved Hide resolved
@dduugg dduugg marked this pull request as ready for review February 18, 2024 23:49
Library/.rubocop.yml Show resolved Hide resolved
Co-authored-by: Markus Reiter <me@reitermark.us>
@MikeMcQuaid MikeMcQuaid merged commit b083b1a into Homebrew:master Feb 19, 2024
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants