rubocop: Formulae with the "lxml" resource have required dependencies #16705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We're moving from `depends_on "python-lxml"` to `resource "lxml" ...` as part of the new Python vendoring plan. - For `resource "lxml"` to work, `uses_from_macos "libxml2"` and `uses_from_macos "libxslt"` are needed in the formulae. - This new RuboCop rule enforces that a formula including the "lxml" resource also include those dependencies.
|
Thank you so much for this! We have already moved some formulae over to using the resource, and will be moving the rest over as time allows. |
|
Thanks! I was also thinking that this would be very useful to just enforce. |
ZhongRuoyu
reviewed
Feb 20, 2024
Library/Homebrew/test/rubocops/resource_requires_dependencies_spec.rb
Outdated
Show resolved
Hide resolved
Library/Homebrew/test/rubocops/resource_requires_dependencies_spec.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
ZhongRuoyu
approved these changes
Feb 20, 2024
MikeMcQuaid
approved these changes
Feb 20, 2024
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?depends_on "python-lxml"toresource "lxml" ...as part of the new Python vendoring plan.resource "lxml"to work,uses_from_macos "libxml2"anduses_from_macos "libxslt"are needed in the formulae.TODO:
depends_on "python-lxml"). Separate PR?