Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/New-Maintainer-Checklist: tell people to avoid forks. #16734

Merged
merged 1 commit into from Feb 23, 2024

Conversation

MikeMcQuaid
Copy link
Member

This was discussed at the AGM. It's no longer needed to avoid "cluttering up clones" because most users use the API for our main repositories now.

It should also simplify security work in future because we can assume anyone who can create a branch on the main repository has write access rather than e.g. having a hardcoded list of maintainers we rely on.

This was discussed at the AGM. It's no longer needed to avoid
"cluttering up clones" because most users use the API for our
main repositories now.

It should also simplify security work in future because we can assume
anyone who can create a branch on the main repository has write access
rather than e.g. having a hardcoded list of maintainers we rely on.
@MikeMcQuaid MikeMcQuaid requested review from a team February 23, 2024 17:24
@Bo98
Copy link
Member

Bo98 commented Feb 23, 2024

It's no longer needed to avoid "cluttering up clones" because most users use the API for our main repositories now.

Still relevant for Homebrew/brew but we should probably not be pulling every branch anyway.

@p-linnane p-linnane merged commit d72f4a8 into master Feb 23, 2024
24 checks passed
@p-linnane p-linnane deleted the maintainers_fork branch February 23, 2024 17:39
@EricFromCanada
Copy link
Member

It's no longer needed to avoid "cluttering up clones" because most users use the API for our main repositories now.

Still relevant for Homebrew/brew but we should probably not be pulling every branch anyway.

The forking UI now includes a "Copy the master branch only" checkbox that's enabled by default.

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants