Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate_disable: add cask deprecate/disable reasons #16743

Merged
merged 3 commits into from Feb 25, 2024

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR adds some additional reasons for deprecate/disable in casks.

I would expect that discontinued would be used when a software is officially discontinued upstream, unmaintained used when a software has not received updates for a long time and may not work as expected on modern hardware, and no_longer_available when the software can longer be sourced from upstream.

It could be worth considering a no_longer_works style option, however this likely overlaps with unmaintained.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane merged commit c6d9592 into Homebrew:master Feb 25, 2024
26 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @bevanjkay!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants