Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ability to skip the duplicate PR check in autobump #16781

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Remove ability to skip the duplicate PR check in autobump #16781

merged 1 commit into from
Mar 1, 2024

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This simply removes the environment variable check. The code was disabled in core around two weeks ago in Homebrew/homebrew-core#163023. We need this PR to land first as explained in Homebrew/actions#506 (comment) to unblock other PRs.

@apainintheneck
Remove ability to skip the duplicate PR check in autobump
4ea6a8c 
This simply removes the environment variable check. The code was disabled in core around two weeks ago in Homebrew/homebrew-core#163023. We need this PR to land first as explained in Homebrew/actions#506 (comment) to unblock other PRs.
@apainintheneck apainintheneck force-pushed the remove-ability-to-skip-dupe-pr-check-in-autobump branch from d6220b0 to 4ea6a8c Compare March 1, 2024 04:48
This was referenced Mar 1, 2024
Merged
Closed
ZhongRuoyu
ZhongRuoyu approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@apainintheneck apainintheneck merged commit 99baaf3 into master Mar 1, 2024
26 checks passed
@apainintheneck apainintheneck deleted the remove-ability-to-skip-dupe-pr-check-in-autobump branch March 1, 2024 05:15
@MikeMcQuaid
Copy link
Member

Thanks @apainintheneck!

ZhongRuoyu added a commit to Homebrew/homebrew-core that referenced this pull request Mar 1, 2024
@ZhongRuoyu
autobump: set HOMEBREW_TEST_BOT_AUTOBUMP
a982e0e 
This is needed for Homebrew/brew#16750.

Note that #163023 is no longer relevant as the ability to skip duplicate
PR check in `brew bump` has been completely removed in
Homebrew/brew#16781.
@ZhongRuoyu ZhongRuoyu mentioned this pull request Mar 1, 2024
Merged
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apainintheneck @MikeMcQuaid @ZhongRuoyu