Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap: revert caching Tap.reverse_tap_migrations_renames #16797

Merged

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This could cause problems if a tap is installed during the lifetime of the program which happens occasionally with Tap#ensure_installed!.

It also seems to be slow mainly because of intermediate arrays and Pathname objects that get created in Tap.each. Maybe that should be optimized instead.

As discussed in #16791 (comment)

This could cause problems if a tap is installed during the lifetime
of the program which happens occasionally with `Tap#ensure_installed!`.

It also seems to be slow mainly because of intermediate arrays and
Pathname objects that get created in `Tap.each`. Maybe that should
be optimized instead.
@apainintheneck apainintheneck added the critical Critical change which should be shipped as soon as possible. label Mar 2, 2024
@apainintheneck apainintheneck merged commit 53c1107 into master Mar 2, 2024
27 checks passed
@apainintheneck apainintheneck deleted the revert-caching-of-reverse-tap-migrations-renames branch March 2, 2024 20:15
@MikeMcQuaid
Copy link
Member

Thanks @apainintheneck!

This could cause problems if a tap is installed during the lifetime of the program which happens occasionally with Tap#ensure_installed!.

Ideally we'd bust all Tap class-level caches every time we add/remove a tap CC @reitermarkus

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants