Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: also use tag when checking GitHub license #16812

Merged
merged 1 commit into from Mar 4, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 4, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Also check tag info to work when URL is a git tag, e.g. current influxdb

git checkout -q masterbrew audit --online --git --only license influxdb; echo $?
influxdb
  * Formula license ["MIT"] does not match GitHub license ["Apache-2.0"].
Error: 1 problem in 1 formula detected.
1git checkout -q formula_auditor-also-check-tagbrew audit --online --git --only license influxdb; echo $?
0gh api 'repos/influxdata/influxdb/license?ref=v2.7.5' | jq .license
{
  "key": "mit",
  "name": "MIT License",
  "spdx_id": "MIT",
  "url": "https://api.github.com/licenses/mit",
  "node_id": "MDc6TGljZW5zZTEz"
}

Signed-off-by: Michael Cho <michael@michaelcho.dev>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit cf7c093 into Homebrew:master Mar 4, 2024
26 checks passed
@cho-m cho-m deleted the formula_auditor-also-check-tag branch March 5, 2024 02:05
cho-m added a commit to Homebrew/homebrew-core that referenced this pull request Mar 22, 2024
Should be possible due to Homebrew/brew#16812

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants