Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TapConfig. #16813

Merged
merged 1 commit into from Mar 7, 2024
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 4, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Only allow Symbols for keys and booleans as values.

@Bo98
Copy link
Member

Bo98 commented Mar 5, 2024

I agree in principle, though this is public API which usually warrants a deprecation cycle. Have we checked nothing else anywhere is using it?

@reitermarkus
Copy link
Member Author

reitermarkus commented Mar 5, 2024

Have we checked nothing else anywhere is using it?

It seems to be only used in tests and in Tap itself.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am OK with this then

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @reitermarkus! Please merge when you're around to handle any regressions.

@reitermarkus reitermarkus merged commit 49910ad into Homebrew:master Mar 7, 2024
26 checks passed
@reitermarkus reitermarkus deleted the tapconfig-sig branch March 7, 2024 14:45
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants