Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope sponsors-maintainers-man-completions.yml to master branch #16819

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This came up when I started pushing some branches directly to the brew repo instead of using a fork (probably a bad idea in hindsight).

As a result of that, the ever friendly brew test bot took it upon itself to update the maintainers on each of the branches I'd updated recently. This was not actually very helpful. We really only need to run this workflow when there are pushes to the master branch.

This came up when I started pushing some branches directly to the
brew repo instead of using a fork (probably a bad idea in hindsight).

As a result of that, the ever friendly brew test bot took it upon
itself to update the maintainers on each of the branches I'd updated
recently. This was not actually very helpful. We really only need
to run this workflow when there are pushes to the master branch.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @apainintheneck!

@MikeMcQuaid MikeMcQuaid merged commit 463eebc into Homebrew:master Mar 5, 2024
27 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants