Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the --overwrite flag to brew upgrade to govern the keg-linking step #16851

Merged
merged 2 commits into from Mar 8, 2024
Merged

Add support for the --overwrite flag to brew upgrade to govern the keg-linking step #16851

merged 2 commits into from Mar 8, 2024

Conversation

boblail
Copy link
Contributor

@boblail boblail commented Mar 7, 2024

FormulaInstaller already supports this (#12691) but I didn't wire it up via brew upgrade and the two can be used largely interchangeably

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@boblail
Add support for the --overwrite flag to brew upgrade to govern th…
3d24da1 
…e keg-linking step

`FormulaInstaller` already supports this (Homebrew#12691) but I didn't wire it up via `brew upgrade` and the two can be used largely interchangeably
carlocab
carlocab approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

MikeMcQuaid
MikeMcQuaid approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank again @boblail!

@MikeMcQuaid MikeMcQuaid merged commit 0a70e49 into Homebrew:master Mar 8, 2024
26 checks passed
@boblail
Copy link
Contributor Author

boblail commented Mar 8, 2024

Thanks, @MikeMcQuaid! Thanks, @carlocab! I appreciate all your work on this essential tool and your quick turnaround on PR reviews! ❤️

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boblail @MikeMcQuaid @carlocab