Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaner: remove pip direct_url.json #16853

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 8, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

One potential way of handling #16012.

brew fetch --quiet asciidoc
Downloaded to: /Users/cho-m/Library/Caches/Homebrew/downloads/6cde15ed2f28f2fd57678757f8fd3d2632f8449cd3534a43d5aedfb1e7cd2cc9--asciidoc--10.2.0.arm64_sonoma.bottle.5.tar.gz
SHA256: 3834a488c93f7a1522c4a596fa383a5cadb27f6045b0a26c17eb8a8c99d30e10brew bottle --verbose --json --only-json-tab asciidoc
==> Determining asciidoc bottle rebuild...
==> Bottling asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gz...
/opt/homebrew/opt/gnu-tar/bin/gtar --create --numeric-owner --mtime=2022-05-22 13:07:31 --sort=name --owner=0 --group=0 --numeric-owner --format=pax --pax-option=globexthdr.name=/GlobalHead.%n,exthdr.name=%d/PaxHeaders/%f,delete=atime,delete=ctime --file /Users/cho-m/Desktop/test/asciidoc/asciidoc--10.2.0.arm64_sonoma.bottle.6.tar asciidoc/10.2.0
./asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gz
  bottle do
    rebuild 6
    sha256 cellar: :any_skip_relocation, arm64_sonoma: "215cdd544ce3046f58f868347c476c8fa83b3391b2a700e6ddd1f9b65b0e9c4f"
  end
Writing asciidoc--10.2.0.arm64_sonoma.bottle.jsonsha256sum asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gz
215cdd544ce3046f58f868347c476c8fa83b3391b2a700e6ddd1f9b65b0e9c4f  asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gzdiffoscope $(brew --cache --quiet asciidoc) asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gz
--- /Users/cho-m/Library/Caches/Homebrew/downloads/6cde15ed2f28f2fd57678757f8fd3d2632f8449cd3534a43d5aedfb1e7cd2cc9--asciidoc--10.2.0.arm64_sonoma.bottle.5.tar.gz
+++ asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gz
│   --- 6cde15ed2f28f2fd57678757f8fd3d2632f8449cd3534a43d5aedfb1e7cd2cc9--asciidoc--10.2.0.arm64_sonoma.bottle.5.tar
├── +++ asciidoc--10.2.0.arm64_sonoma.bottle.6.tar
│ ├── file list
│ │ @@ -144,14 +144,13 @@
│ │  -rw-r--r--   0        0        0     8043 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc/resources/themes/volnitsky/volnitsky.css
│ │  -rw-r--r--   0        0        0     1954 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc/resources/xhtml11-quirks.conf
│ │  -rw-r--r--   0        0        0    23017 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc/resources/xhtml11.conf
│ │  -rw-r--r--   0        0        0     5810 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc/utils.py
│ │  drwxr-xr-x   0        0        0        0 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/
│ │  -rw-r--r--   0        0        0        4 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/INSTALLER
│ │  -rw-r--r--   0        0        0     3103 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/METADATA
│ │ --rw-r--r--   0        0        0    11232 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/RECORD
│ │ +-rw-r--r--   0        0        0    11135 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/RECORD
│ │  -rw-r--r--   0        0        0        0 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/REQUESTED
│ │  -rw-r--r--   0        0        0       92 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/WHEEL
│ │ --rw-r--r--   0        0        0       92 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/direct_url.json
│ │  -rw-r--r--   0        0        0       74 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/entry_points.txt
│ │  -rw-r--r--   0        0        0        9 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/top_level.txt
│ │  -rw-r--r--   0        0        0      361 2022-05-22 17:07:31.000000 asciidoc/10.2.0/libexec/pyvenv.cfg
│ ├── asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/RECORD
│ │ @@ -1,15 +1,14 @@
│ │  ../../../bin/a2x,sha256=fUHfht_0WrUAbZS6OYXl2eFJJyRIB7ifIma9OIdKKHQ,248
│ │  ../../../bin/asciidoc,sha256=jM0HujAKip0JkiUIYj8afLlQeIJCUYVUbSS6KFdnU4g,253
│ │  asciidoc-10.2.0.dist-info/INSTALLER,sha256=zuuue4knoyJ-UwPPXg8fezS7VCrXJQrAP7zeNuwvFQg,4
│ │  asciidoc-10.2.0.dist-info/METADATA,sha256=vz_QriFIZVmtYNMYdzLAmW-MAbp3U03RLCUDn5XF7Go,3103
│ │  asciidoc-10.2.0.dist-info/RECORD,,
│ │  asciidoc-10.2.0.dist-info/REQUESTED,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
│ │  asciidoc-10.2.0.dist-info/WHEEL,sha256=oiQVh_5PnQM0E3gPdiz09WCNmwiHDMaGer_elqB3coM,92
│ │ -asciidoc-10.2.0.dist-info/direct_url.json,sha256=ykFbGlFZbP-2BavIV-8iH_TRn-T3ZLnZJClmXTbvCck,92
│ │  asciidoc-10.2.0.dist-info/entry_points.txt,sha256=3jQsp9jYnfMEZ7y8cTuP4Qm-19S_MEMhvCI0dRBXGBg,74
│ │  asciidoc-10.2.0.dist-info/top_level.txt,sha256=2hjZ3yyYNMKIvJ4wi_leY0JUW3pxQYbost93innM14Q,9
│ │  asciidoc/__init__.py,sha256=oxCHMXaof2ZMW7jxTFqEvnGfWScR78sgNmd7pAu2Cmk,879
│ │  asciidoc/__main__.py,sha256=JIozLnQ6XB3DOpP7T9jz5sy67TPd3AtlBQZ0AdCJe4I,173
│ │  asciidoc/__metadata__.py,sha256=eu9k5_nPykdhfNVpDNBhrl20eqKvU7fGfYqx8mNVUWk,114
│ │  asciidoc/a2x.py,sha256=hxVfZ5Ct4xX2U5-ZisAW6GH62Ya0byhHaW_Xft8Y0Xo,38923
│ │  asciidoc/api.py,sha256=AQ95q3zIE3p8kPxGzdnpupHP5eymHB8TrdQZm0H2hZc,1837

Signed-off-by: Michael Cho <michael@michaelcho.dev>
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Although hacky, it does at least seem to match what Debian does: https://salsa.debian.org/python-team/tools/dh-python/-/commit/2ef6ff13748984258d5da000c17d9cdad707b9ae

@MikeMcQuaid MikeMcQuaid merged commit 8cce987 into Homebrew:master Mar 8, 2024
26 checks passed
@MikeMcQuaid
Copy link
Member

Great catch @cho-m!

@cho-m cho-m deleted the cleaner-direct_url.json branch March 8, 2024 14:03
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants