New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various brew update
behaviour improvements
#16855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense 👍
- Output a message every time auto-update is run rather than a 3 second timer. This makes it more obvious that Homebrew isn't just sitting doing nothing for 2.9 seconds. - Output a message when running `brew update` so Homebrew doesn't just sit there silently doing nothing. - Update all taps when `brew update` is run, not just those hosted on GitHub. This makes it more obvious that people don't need to explictly run `brew update` "just in case". - As a result of this, remove `brew tap --force-auto-update` as it's no longer necessary.
6cafde4
to
9ac3182
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Thanks!
# exceeds 3 seconds. | ||
auto-update-timer() { | ||
sleep 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong opinion, but feels nicer to try tweaking the 3 second timer before jumping to showing it all the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlocab I think having it (almost) immediately print output makes the output more responsive (and, in turn, Homebrew "feel" faster).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying this out I agree that having the immediate feedback feels nicer. Otherwise I wonder whether brew has started updating, or whether it's just blocked on loading files or something.
This is a great update @MikeMcQuaid ! |
brew update
so Homebrew doesn't just sit there silently doing nothing.brew update
is run, not just those hosted on GitHub. This makes it more obvious that people don't need to explictly runbrew update
"just in case".brew tap --force-auto-update
as it's no longer necessary.