Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: track removed links & dirs during dry-run #16871

Merged
merged 1 commit into from Mar 11, 2024
Merged

cleanup: track removed links & dirs during dry-run #16871

merged 1 commit into from Mar 11, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 10, 2024

This allows dry-run to display any directories that will be removed as a result of previous removal steps.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just to make --dry-run closer to actual removals.

@cho-m
cleanup: track removed links & dirs during dry-run
29175df 
This allows dry-run to display any directories that will be removed
as a result of previous removal steps.

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m force-pushed the cleanup-dryrun-print-dirs branch from 2920f74 to 29175df Compare March 10, 2024 23:02
@cho-m cho-m mentioned this pull request Mar 10, 2024
Merged
7 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thanks again @cho-m!

@cho-m cho-m merged commit 545b830 into Homebrew:master Mar 11, 2024
26 checks passed
@cho-m cho-m deleted the cleanup-dryrun-print-dirs branch March 11, 2024 17:44
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cho-m @MikeMcQuaid @carlocab