dev-cmd/bump: skip Repology checks in CI for livecheckables #16887
Conversation
| @@ -112,6 +112,12 @@ def bump | |||
| end | |||
| end | |||
|
|
|||
| sig { params(formula_or_cask: T.any(Formula, Cask::Cask), args: CLI::Args).returns(T::Boolean) } | |||
| def skip_repology?(formula_or_cask, args:) | |||
| (ENV["CI"].present? && args.open_pr? && formula_or_cask.livecheckable?) || | |||
There was a problem hiding this comment.
Do we really call brew bump on CI to do anything other than open PRs?
There was a problem hiding this comment.
We don't. Other people however...
|
I'm curious as to how much faster this will make things. |
|
I could definitely (unscientifically) feel the change locally. The current autobump is quite slow at one hour: https://github.com/Homebrew/homebrew-core/actions/workflows/autobump.yml, so we'll see what it's like after merging this. #16886 also removes a slow open PR check that will save a couple seconds per formula too. Not going to suddenly make it 10 minutes but if the two together make it say 50-55 minutes I consider that successful. And if not, it'll at least mean we're no longer sending thousands of network requests to Repology servers on a regular basis. |
|
https://github.com/Homebrew/homebrew-core/actions/runs/8304989363/job/22731571713 2x faster (~1hr -> ~30 mins) |
|
Amazing work again @Bo98! |
When we have a livecheck in a formula, Repology is purely informational - it is never used to perform the actual bump. In a CI autobump environment, this is wasted network requests and adds a couple seconds to each bump so let's skip it.