Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions warning/error annotations for deprecations/disables. #16890

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Mar 14, 2024

This should make these messages, particular warnings, more obvious to GitHub Actions users.

There's an argument perhaps we should do this more broadly for all warning/error messages but: this feels like a good start.

CC @Bo98 as this came out one of our discussions.

This should make these messages, particular warnings, more obvious to
GitHub Actions users.

There's an argument perhaps we should do this more broadly for all
warning/error messages but: this feels like a good start.
@MikeMcQuaid MikeMcQuaid requested review from a team March 14, 2024 09:55
Library/Homebrew/cask/installer.rb Outdated Show resolved Hide resolved
Library/Homebrew/cask/installer.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/kernel.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/kernel.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_installer.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_installer.rb Outdated Show resolved Hide resolved
Co-authored-by: Bo Anderson <mail@boanderson.me>
@MikeMcQuaid MikeMcQuaid requested a review from Bo98 March 14, 2024 14:09
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid merged commit 92ad6a8 into master Mar 14, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the github_actions_deprecated_disabled_warning_error_annotations branch March 14, 2024 16:39
@MikeMcQuaid
Copy link
Member Author

Thanks for corrections and review @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants