dev-cmd/bump-formula-pr: replace partial version in URL #16904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongRuoyu
approved these changes
Mar 17, 2024
|
cc @Bo98 as related to Homebrew/homebrew-core#166305 (comment) |
This was referenced Mar 17, 2024
cho-m
commented
Mar 17, 2024
cho-m
force-pushed
the
bump-formula-pr-partial-versions
branch
2 times, most recently
from
b969bfd
to
b38a82a
Compare
For now, restrict to partial version excluding the last part, i.e.
version with major.minor.patch will result in attempting to replace any
occurrences of "/#{major}.#{minor}/" or "/v#{major}.#{minor}/".
This should take care of common situations like GNOME, KDE, and
SourceForge URLs. It should also help with URLs like `util-linux`.
It may result in incorrect replacements if URL has partial version based
on another versioning scheme like the API version or if there are some
equivalent numbers in URL that happen to match
Signed-off-by: Michael Cho <michael@michaelcho.dev>
cho-m
force-pushed
the
bump-formula-pr-partial-versions
branch
from
b38a82a
to
709afd5
Compare
6 tasks
MikeMcQuaid
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, restrict to partial version excluding the last part, i.e. version with major.minor.patch will result in attempting to replace any occurrences of "/#{major}.#{minor}/" or "/v#{major}.#{minor}/".
This should take care of common situations like GNOME, KDE, and SourceForge URLs. It should also help with URLs like
util-linux.It may result in incorrect replacements if URL has partial version based on another versioning scheme like the API version or if there are some equivalent numbers in URL that happen to match
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Could go stricter or looser in restrictions. Not sure if any incorrect replacements yet.
This won't handle formulae like:
mysql- https://cdn.mysql.com/Downloads/MySQL-8.3/mysql-boost-8.3.0.tar.gzrtf2latex2e- https://downloads.sourceforge.net/project/rtf2latex2e/rtf2latex2e-unix/2-2/rtf2latex2e-2-2-3.tar.gzIf we do hit incorrect replacements, we could test out multiple options for
url. In case ofmirror, we would still need to guess as these don't always exist at time of bump.