Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Tapioca::Compilers::Args test #16909

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Mar 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves https://github.com/Homebrew/brew/actions/runs/8329015201/job/22790407761 – let's just validate the keys, since it seems that the values vary by OS.

@MikeMcQuaid
Copy link
Member

Thanks for quick fix @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 8e67ee2 into master Mar 18, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dduugg-fix-flaky-test branch March 18, 2024 16:37
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants