Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BrewTestBot critical approval process. #16916

Merged
merged 1 commit into from Mar 19, 2024
Merged

Conversation

MikeMcQuaid
Copy link
Member

We seem to have enough maintainers across enough timezones that this is no longer necessary any more (and it presents a bit of a security risk).

CC @Homebrew/brew and @Homebrew/maintainers for thoughts.

We seem to have enough maintainers across enough timezones that this is
no longer necessary any more (and it presents a bit of a security risk).
@MikeMcQuaid MikeMcQuaid requested review from a team March 19, 2024 08:57
@MikeMcQuaid
Copy link
Member Author

Thanks all, glad to have unanimous agreement here so far so 🚢ing.

@MikeMcQuaid MikeMcQuaid merged commit 6b07323 into master Mar 19, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the no_critical_approval branch March 19, 2024 16:06
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants