Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/utils/github_spec: filter further to fix test failure #16922

Merged
merged 1 commit into from Mar 19, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 19, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Signed-off-by: Michael Cho <michael@michaelcho.dev>
is: "closed")
is: "issue",
Copy link
Member Author

@cho-m cho-m Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, is: closed is giving me multiple results which doesn't match manual GitHub search. Currently, filtering on is: issue and no: milestone gives one result.

brew ruby -e 'pp GitHub.search_issues("brew search", repo: "Homebrew/legacy-homebrew", author: "MikeMcQuaid", is: "closed").map { |out| out["title"] }'
["Shall we move more things to taps?",
 "upgrade: announce usage of --all.",
 "Remove (almost) everything",
 "Shall we run `brew update` automatically?",
 "bin/brew: move logic to Library.",
 "install: search when formula isn't found.",
 "Remove MD5 support.",
 "config: fail when HOMEBREW_BREW_FILE is unset.",
 "Use `(installed)` and emoji ticks consistently.",
 "Import docs from wiki."]brew ruby -e 'pp GitHub.search_issues("brew search", repo: "Homebrew/legacy-homebrew", author: "MikeMcQuaid", is: "issue").map { |out| out["title"] }'
["Shall we move more things to taps?", "Shall we run `brew update` automatically?"]brew ruby -e 'pp GitHub.search_issues("brew search", repo: "Homebrew/legacy-homebrew", author: "MikeMcQuaid", is: "issue", no: "milestone").map { |out| out["title"] }'
["Shall we move more things to taps?"]

@cho-m cho-m marked this pull request as ready for review March 19, 2024 21:05
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 6c5da0d into Homebrew:master Mar 19, 2024
23 checks passed
@cho-m cho-m deleted the test-github-spec branch March 19, 2024 21:22
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants