Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/abstract_command_spec: rename cat to fix completions test #16934

Merged
merged 1 commit into from Mar 22, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 21, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Debugging a failing testcase - https://github.com/Homebrew/brew/actions/runs/8378122352/job/22941960641#step:12:41

@cho-m cho-m force-pushed the test-shell-completion-error branch 4 times, most recently from 37dbda7 to ae7c558 Compare March 21, 2024 23:31
@cho-m cho-m changed the title commands: debugging update_shell_completions! test/abstract_command_spec: rename cat to fix completions test Mar 21, 2024
@cho-m cho-m marked this pull request as ready for review March 21, 2024 23:31
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m force-pushed the test-shell-completion-error branch from ae7c558 to 57b7f39 Compare March 21, 2024 23:58
@dduugg dduugg merged commit 1a62a63 into Homebrew:master Mar 22, 2024
25 checks passed
@cho-m cho-m deleted the test-shell-completion-error branch March 22, 2024 01:25
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants