Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap-info cmd: skip untapped core taps #16976

Merged

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented Mar 30, 2024

When homebrew/core or homebrew/cask are untapped brew tap-info fails because Tap.each includes them and tap.private? fails without a git repo interrogate.

This restores the behavior of brew tap-info before #16710

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@rrotter rrotter force-pushed the tap-info-skip-untapped-core-taps branch from 2caf3ce to 671140b Compare March 30, 2024 05:29
When homebrew/core or homebrew/cask are untapped `brew tap-info` fails because
Tap.each includes them and tap.private? fails without a git repo interrogate.

This restores the behavior of `brew tap-info` before #16710
@rrotter rrotter force-pushed the tap-info-skip-untapped-core-taps branch from 671140b to d856d88 Compare March 30, 2024 05:41
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce this locally.

$ brew untap homebrew/cask
Untapping homebrew/cask...
Untapped 4417 casks (4,965 files, 382.0MB).
$ brew tap-info
Error: No available tap homebrew/cask.
Run brew tap --force homebrew/cask to tap homebrew/cask!

The fix seems to work too.

$ brew tap-info
10 taps, 1 private, 7022 formulae, 16 commands, 17,037 files, 759.5MB

@apainintheneck apainintheneck merged commit 5128d52 into Homebrew:master Mar 30, 2024
25 checks passed
@apainintheneck
Copy link
Contributor

Thanks for your first contribution to Homebrew!

@rrotter rrotter deleted the tap-info-skip-untapped-core-taps branch March 30, 2024 23:52
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants