Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: handle some edge cases #16992

Merged
merged 1 commit into from
Apr 1, 2024
Merged

cleanup: handle some edge cases #16992

merged 1 commit into from
Apr 1, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 1, 2024 •
edited

  • Bottle manifests are difficult to determine whether they're outdated so we will now only remove them when the formula is up-to-date. When up-to-date, we will get the latest manifest version and compare like that.
  • For bottles themselves, adjust formula version check to use pkg_version as this is actually how it was always parsed and we were never checking the right one.

@Bo98 Bo98 mentioned this pull request Apr 1, 2024
Merged
MikeMcQuaid
MikeMcQuaid approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks again @Bo98!

@Bo98 Bo98 merged commit 865d38a into master Apr 1, 2024
25 checks passed
@Bo98 Bo98 deleted the cleanup-edgecase branch April 1, 2024 14:05
@github-actions github-actions bot added the outdated PR was locked due to age label May 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bo98 @MikeMcQuaid